Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export cli-spinners #217

Closed
Poyoman39 opened this issue Sep 1, 2022 · 2 comments · Fixed by #222
Closed

Export cli-spinners #217

Poyoman39 opened this issue Sep 1, 2022 · 2 comments · Fixed by #222
Labels
enhancement help wanted

Comments

@Poyoman39
Copy link

This is a feature request. It would be usefull to export the available cli-spinners, so that we can do stuff like random spinner with ora.

Currently a "workaround" would consists in importing cli-spinner directly which is a bit "less safe", if ora change it's dependancy to this lib or add spinners not in cli-spinner.

What do you think about this feature ? ^^
@sindresorhus
Copy link
Owner

Sure. We can add a spinners named export. Needs docs, TS types, and a test.

@Poyoman39
Copy link
Author

I gonna upgrade my PR ;)

@tommy-mitchell tommy-mitchell mentioned this issue Mar 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export cliSpinners as spinners tommy-mitchell/ora
2 participants
@sindresorhus @Poyoman39