Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback with single argument not error first #46

Closed
lambduli opened this issue Jul 12, 2017 · 0 comments
Closed

Callback with single argument not error first #46

lambduli opened this issue Jul 12, 2017 · 0 comments

Comments

@lambduli
Copy link

lambduli commented Jul 12, 2017

EDIT: Sorry for nonsense request - one of my weaker moments - you can close it.

Hello,
If function passed into pify has only one argument it's usually something like data, result, or so. This callback has only option for success, thus must be used with additional options - errorFirst: false.

Would it be possible to consider change of default behavior, since from #31 we have support for not error first callbacks?

When callback.length is 1, function takes single argument and it would be considered as errorFirst: false by default.
It would be less verbose.
If it would or wouldn't be less clear is on your consideration.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants