Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCL: CL command returns success in case of uncaught exception #66

Open
metawilm opened this issue Mar 12, 2017 · 2 comments
Open

ABCL: CL command returns success in case of uncaught exception #66

metawilm opened this issue Mar 12, 2017 · 2 comments

Comments

@metawilm
Copy link

When ABCL encounters a NullPointerException and aborts execution, still exit code 0 is returned from the CL command. This means e.g. Travis considers the test a success. I think it should return a nonzero value to indicate failure instead.

Example Travis-CI job log: https://travis-ci.org/metawilm/cl-python/jobs/210320828

The Lisp form being evaluated looks essentially like:

(warn "Before ignore-errors")
(ignore-errors (...test code...))
(warn "After ignore-errors")

The output says:

WARNING: Before ignore-errors
...
Exception in thread "interpreter" java.lang.NullPointerException
	at org.armedbear.lisp.StandardObject$pf_standard_instance_access.execute(StandardObject.java:446)
	at org.armedbear.lisp.Symbol.execute(Symbol.java:814)
        ...
The command "cl -e ..." exited with 0.

without showing the "After ignore-errors" warning, indicating the NPE was not caught at the Lisp level.

@metawilm
Copy link
Author

Wrapping the test form inside UNWIND-PROTECT does lead to the Lisp cleanup forms being evaluated after the Java NPE. So it's possible to manually return a desired exit code there. But the exception backtrace is then not printed anymore, so this is not ideal.
Example: https://travis-ci.org/metawilm/cl-python/jobs/210332741

@KeenS
Copy link
Collaborator

KeenS commented Mar 13, 2017

@metawilm Thank you for reporting bugs. However as described in README, CIM is deprecated and no more be maintained.
If you want to run tests on various CL impls at CI, consider using roswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants