Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes version # #448

Open
celskeggs opened this issue Nov 28, 2019 · 1 comment
Open

Fix kubernetes version # #448

celskeggs opened this issue Nov 28, 2019 · 1 comment

Comments

@celskeggs
Copy link
Member

celskeggs commented Nov 28, 2019

Running "kubectl version" gives us the following:

Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"{gitMajor}", Minor:"{gitMinor}", GitVersion:"{gitVersion}", GitCommit:"{gitCommit}", GitTreeState:"{gitTreeState}", BuildDate:"{buildDate}", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

We should fix this to give us something more reasonable. See #105 for the last time this happened.

Given that this is a regression, we should set up a test to confirm this continues to work in the future.

@celskeggs
Copy link
Member Author

This is blocking #29, because Rook requires correct version reporting to function. This is now much higher-priority!

@celskeggs celskeggs self-assigned this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant