Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications marked as unread disappear if the server stops returning it #96

Open
sirbrillig opened this issue Dec 21, 2020 · 2 comments · Fixed by #97
Open

Notifications marked as unread disappear if the server stops returning it #96

sirbrillig opened this issue Dec 21, 2020 · 2 comments · Fixed by #97

Comments

@sirbrillig
Copy link
Owner

Since there's no way to "mark as unread" in the github notifications API (at least, last time I checked), the "mark as unread" behavior in gitnews-menubar is internal to the app's local cache of the data. However, since github thinks the notification is already read, it will eventually be removed from the notifications API response since it only lists recent notifications.

It would be nice if a notification, when marked as unread, would stay around until it was clicked or marked as read. Extending this thought, the notification shouldn't immediately disappear after it has been marked as read either; perhaps we could use an internal expiration system in general.

@sirbrillig
Copy link
Owner Author

The persistence was buggy and was reverted, so this is an issue again.

@sirbrillig
Copy link
Owner Author

This is related to #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant