Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 support #83

Closed
jbolila opened this issue Jun 3, 2018 · 4 comments
Closed

utf8 support #83

jbolila opened this issue Jun 3, 2018 · 4 comments

Comments

@jbolila
Copy link

jbolila commented Jun 3, 2018

sk --ansi -i -c 'rg -S -n --color=always "{}"'

In the response the utf8 characters aren't showing correctly:

_empty_filter

although after the first character everything look fine:

_empty_filter_one

@lotabout
Copy link
Collaborator

lotabout commented Jun 3, 2018

@jbolila It is actually rg's problem. rg did not output the correct character with empty pattern and color enabled. Please run the command to confirm its output:

rg -S -n --color=always ''

Normally this doesn't bother me so much though.

@jbolila
Copy link
Author

jbolila commented Jun 3, 2018

thank you @lotabout you're right.

❯ rg -S -n --color=always '' Cargo.toml
1:[package]
2:authors = ["Jo[0mo Bolila <j**>"]
..
❯ rg -S -n --color=always 'au' Cargo.toml
2:authors = ["João Bolila <j**>"]

@BurntSushi
Copy link

@lotabout Could you elaborate on your suggestion to use ag here? ag returns an error if you provide it with an empty pattern. So how do you even use ag in the first place here?

@lotabout
Copy link
Collaborator

lotabout commented Jun 4, 2018

@BurntSushi Sorry, I was wrong. I've updated my comment.

I was using ag before I found rg for several years and never met such problem. But I do forget that it won't accept empty pattern. Sorry for giving the wrong information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants