Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the directory where fetcher are caching downloaded file #641

Closed
glemaitre opened this issue Jul 18, 2023 · 0 comments · Fixed by #652
Closed

Change the directory where fetcher are caching downloaded file #641

glemaitre opened this issue Jul 18, 2023 · 0 comments · Fixed by #652

Comments

@glemaitre
Copy link
Member

I see that the downloaded files are stored directly in a module of the package (at least for the figshare files) using the function get_data_dir.

It would be a better practice to store the file in a home folder. In scikit-learn, we have these two functions that can help:

https://github.com/scikit-learn/scikit-learn/blob/fa8cd70bf33f4e64fed17d2952ffc7b900381e40/sklearn/datasets/_base.py#L35-L90

I assume that these functions could almost be reused as-is and just set the data_home properly for skrub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move default location of data to the user home folder flefebv/skrub
1 participant
@glemaitre