Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options are ignored when url option provided #43

Open
acco opened this issue Apr 1, 2020 · 0 comments · May be fixed by #103
Open

Options are ignored when url option provided #43

acco opened this issue Apr 1, 2020 · 0 comments · May be fixed by #103
Labels
enhancement New feature or request

Comments

@acco
Copy link

acco commented Apr 1, 2020

Here's the offending line:

https://github.com/kyknow/nestjs-redis/blob/master/lib/redis-client.provider.ts#L17

If you pass in a url, any other options are ignored:

RedisModule.register({
      url: process.env.REDIS_URL,
      keyPrefix: process.env.REDIS_KEY_PREFIX,
    }),

What's the intended behavior here? If the URL overwrites all other options, we should document and enforce with types.

Thanks!
Anthony
@skunight skunight added the enhancement New feature or request label May 30, 2020
@dylanseago dylanseago linked a pull request Sep 2, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always pass redis options through to ioredis constructor dylanseago/nestjs-redis
2 participants
@skunight @acco