Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisOptions: field name of base interface is already is use for name of master in SentinelConnector of ioredis #54

Open
nexus opened this issue Aug 21, 2020 · 1 comment · May be fixed by #59
Open

RedisOptions: field name of base interface is already is use for name of master in SentinelConnector of ioredis #54

nexus opened this issue Aug 21, 2020 · 1 comment · May be fixed by #59

Comments

@nexus
Copy link

nexus commented Aug 21, 2020

Because export interface RedisModuleOptions extends RedisOptions, field name is already in use by ioredis for name of master in SentinelConnector. You should use a different field for multi-client connection. Otherwise, it is not possible to create more than 1 client with Sentinel setup.
@zodiac1214 zodiac1214 linked a pull request Oct 8, 2020 that will close this issue
Open
@aashutoshrathi
Copy link

@skunight Please update on when this will be merged. I had to create a forked package as this is a critical issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 54: rename name -> clientName so we can use sentinel zodiac1214/nestjs-redis
2 participants
@nexus @aashutoshrathi