Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect resource reference on declarative documentation #189

Open
hash-d opened this issue Nov 6, 2023 · 0 comments
Open

Incorrect resource reference on declarative documentation #189

hash-d opened this issue Nov 6, 2023 · 0 comments

Comments

@hash-d
Copy link
Member

hash-d commented Nov 6, 2023

https://skupper.io/docs/declarative/index.html#skupper-annotations

The documentation at Configuring services using annotations instructs to

$ kubectl create deployment hello-world-backend --image quay.io/skupper/hello-world-backend

then

$ kubectl annotate deployment backend "skupper.io/address=backend" "skupper.io/port=8080" "skupper.io/proxy=tcp"

Notice that the deployment name is different between the commands: hello-world-backend vs backend. As on the text, the second command fails:

$ kubectl annotate deployment backend "skupper.io/address=backend" "skupper.io/port=8080" "skupper.io/proxy=tcp"
Error from server (NotFound): deployments.apps "backend" not found

Changing the name makes it work:

$ kubectl annotate deployment hello-world-backend "skupper.io/address=backend" "skupper.io/port=8080" "skupper.io/proxy=tcp"
deployment.apps/hello-world-backend annotated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant