Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import started picking up node version of a module / "browser" export is ignored #361

Open
Inviz opened this issue Sep 15, 2023 · 3 comments

Comments

@Inviz
Copy link

Inviz commented Sep 15, 2023

Hello. We've been using skypack for a while on codepen, and it started failing recently. Investigation shows that skypack picks conditional export meant for server.

Imported file is @sitecore-feaas/clientside/react.

Here's what export looks like:

    "./react": {
      "localhost": "./build/ui/react.js",
      "types": "./types/ui/react.d.ts",
      "browser": "./dist/browser/react.esm.js",
      "import": "./dist/node/react.esm.js",
      "require": "./dist/node/react.cjs",
      "default": "./dist/node/react.esm.js"
    },

So the served file tries to import node:vm package, is only imported on the server version of a file. browser export is ignored by skypack. It was not the case before.

Any ideas?

@Inviz Inviz changed the title Import started picking up node version of a module Import started picking up node version of a module / "browser" export is ignored Sep 15, 2023
@Inviz
Copy link
Author

Inviz commented Sep 18, 2023

@FredKSchott is skypack maintained? Trying to evaluate if it's worth waiting for a fix, or i should be migrating away.

The issue at hand seems to be like a serious regression which only started happening recently... so i guess that is related to some changes? is there a better channel to connect to the developers?

We are using skypack in code examples generated on codepen.

@soegaard
Copy link

@FredKSchott

An official statement of what to expect with regards to Skypack would be classy.
Leaving things hanging like this, results in inconvenience at best for too many people.

I understand that it is hard to close down a project ( even temporarily),
but it might be the best thing to do at the moment.

FWIW I enjoyed using Skypack for a long time and would have liked it to succeed.

@Inviz
Copy link
Author

Inviz commented Oct 23, 2023

We moved to jsdelivr which offers similar functionality now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants