Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP connections should be persistent (not closed after each batch) #40

Closed
parasj opened this issue Jan 9, 2022 · 0 comments · Fixed by #41
Closed

TCP connections should be persistent (not closed after each batch) #40

parasj opened this issue Jan 9, 2022 · 0 comments · Fixed by #41

Comments

@parasj
Copy link
Contributor

parasj commented Jan 9, 2022

Based on my reading of the code, it looks like the connection isn't persistent --- the destination port is left listening, but a separate connection is still used for each batch of chunks.

I'm approving since it improves bandwidth, but I still think that keeping the TCP connection itself alive for a long time is good, to avoid ramping up congestion control each time.

Originally posted by @samkumar in #38 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant