Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SupportedInterfaceOrientations Horizontal fixed #398

Closed
moheny opened this issue Jun 17, 2018 · 3 comments · Fixed by #399
Closed

SupportedInterfaceOrientations Horizontal fixed #398

moheny opened this issue Jun 17, 2018 · 3 comments · Fixed by #399
Labels
bug hacktoberfest

Comments

@moheny
Copy link

moheny commented Jun 17, 2018

As we all know we had problem with the supportedInterfaceOrientations property which doesn't take much effect.
I have fixed this issue by injecting the SIO property into the ActionSheetVC.
https://github.com/moheny/ActionSheetPicker-3.0/tree/supportedInterfaceOrientations-fix
@moheny moheny mentioned this issue Jun 17, 2018
Merged
@skywinder
Copy link
Owner

Dear @moheny, Thanks for the feedback! I but my comments to the PR with the fix.

@skywinder skywinder added the bug label Jul 4, 2018
@moheny
Copy link
Author

moheny commented Jul 25, 2018

@skywinder Can you please review it again.

@moheny
Copy link
Author

moheny commented Feb 14, 2019

@skywinder Is there any reason for the delay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Supported interface orientations fix moheny/ActionSheetPicker-3.0
2 participants
@skywinder @moheny