Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with iOS 8 beta #9

Closed
jyc66 opened this issue Jul 11, 2014 · 9 comments
Closed

Issue with iOS 8 beta #9

jyc66 opened this issue Jul 11, 2014 · 9 comments

Comments

@jyc66
Copy link

jyc66 commented Jul 11, 2014

Compatibility issues still exists after forking project. Just putting this here for tracking purposes.

@skywinder
Copy link
Owner

I know.
I want to figure out something with this later.
Just put link to older issue in root repo: #111

@michaelnew
Copy link

It looks like the problem is caused by adding a subview to a UIActionSheet. http://stackoverflow.com/questions/24330152/showing-a-uipickerview-with-uiactionsheet-in-ios8-not-working

@chrisballinger
Copy link

Ah I am experiencing this problem... any workarounds?

@chrisballinger
Copy link

Looks like subclassing UIActionSheet is fundamentally flawed:

UIActionSheet is not designed to be subclassed, nor should you add views to its hierarchy. If you need to present a sheet with more customization than provided by the UIActionSheet API, you can create your own and present it modally with presentViewController:animated:completion:.

Perhaps it's time for a rewrite...

@skywinder
Copy link
Owner

@mikenew12 thanks for the link.
Indeed. It seems that it will be a lot of refacktoring work..

@chrisballinger
Copy link

This is what I ended up doing: https://github.com/Burning-Man-Earth/iBurn-iOS/blob/master/iBurn/BRCStringPickerView.m

I don't like it as much :(

@skywinder
Copy link
Owner

Hooray, guys!
Here comes the sun!
I eliminate dummy UIActionSheet And now everything is works!
Please, update your versions to 1.0.15.
Besides, I change a little bit animation. Now background color fade smoothly. It looks better, IMO.
If someone want to perform old animation style - let me know - I will add special flag for it.

@chrisballinger
Copy link

@skywinder Awesome! Now if only I didn't spend an afternoon reimplementing my own version from scratch :)

@Jack-s
Copy link

Jack-s commented Aug 12, 2014

@skywinder I think your update breaks landscape mode...
I opened a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants