Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill Bubble Theme Issue! #1094

Closed
ahmadawais opened this issue Nov 1, 2016 · 5 comments
Closed

Quill Bubble Theme Issue! #1094

ahmadawais opened this issue Nov 1, 2016 · 5 comments

Comments

@ahmadawais
Copy link

ahmadawais commented Nov 1, 2016

In bubble theme of Quill, the toolbar stops appearing after adding an image, or h1 or lists. Also the shortcuts do not work. E.g. I cannot make a word bold by ⌘ + B.

Steps for Reproduction
image

  1. Visit this codepen
  2. Step Two: Add an image and press enter to move on the new line
  3. Step Three: Add some text and select it to make the tooltip appear but it won't

Expected behavior:
Tooltip should appear
Actual behavior:
Tooltip won't appear now.
Platforms:

Include browser, operating system and respective versions

Version:
Latest Chrome, macOS El Captian

Run Quill.version to find out
1.1.3

@ahmadawais
Copy link
Author

@benbro Sorry for the tag, but can you take a look? I think it is a real bug.

@benbro
Copy link
Contributor

benbro commented Nov 3, 2016

Try to create some empty lines below the text and select it again.
Related:
#851
#941

@ahmadawais
Copy link
Author

@benbro Yes, after adding some empty lines it starts working. It's a bug. How do I fix that? Always have some empty lines or is it fixed in the dev release?

@ahmadawais
Copy link
Author

ahmadawais commented Nov 3, 2016

When it goes out of the view and I add two empty lines at the end then the toolbar appears again. How do I fix it?

UPDATE: I just the second link you left was a PR fixing the issue.

@jhchen
Copy link
Member

jhchen commented Nov 3, 2016

It's showing up but being covered. The simple solution is to add some bottom padding: http://codepen.io/quill/pen/vyYNaX. The 2nd PR has issues needing resolution before merger as stated in my comment.

@jhchen jhchen closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants