From 2189f72646c6c5b36bd2afa147c52c706289206c Mon Sep 17 00:00:00 2001 From: uhunny Date: Tue, 15 Aug 2023 21:31:18 -0400 Subject: [PATCH 1/2] adding manufest property for token url configs --- .slack/apps.json | 1 + src/providers/oauth2/types.ts | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 .slack/apps.json diff --git a/.slack/apps.json b/.slack/apps.json new file mode 100644 index 00000000..9e26dfee --- /dev/null +++ b/.slack/apps.json @@ -0,0 +1 @@ +{} \ No newline at end of file diff --git a/src/providers/oauth2/types.ts b/src/providers/oauth2/types.ts index 4fae724c..c36bb86a 100644 --- a/src/providers/oauth2/types.ts +++ b/src/providers/oauth2/types.ts @@ -8,6 +8,10 @@ export type OAuth2ProviderIdentitySchema = { }; }; +export type tokenUrlConfigSchema = { + "uses_basic_authentication_scheme"?: boolean; +}; + export type OAuth2ProviderOptions = { /** Client id for your provider */ "client_id": string; @@ -19,6 +23,8 @@ export type OAuth2ProviderOptions = { "authorization_url"?: string; /** Token url for your provider. Required for CUSTOM provider types. */ "token_url"?: string; + /** Optional configs for token url. Required for CUSTOM provider types. */ + "token_url_config"?: tokenUrlConfigSchema; /** Identity configuration for your provider. Required for CUSTOM provider types. */ "identity_config"?: OAuth2ProviderIdentitySchema; /** Optional extras dict for authorization url for your provider. Required for CUSTOM provider types. */ From a50ac0ff1c14d5ff51081fc76311696cae2d2ddd Mon Sep 17 00:00:00 2001 From: uhunny Date: Tue, 15 Aug 2023 21:37:14 -0400 Subject: [PATCH 2/2] adding pkce boolean field --- src/providers/oauth2/types.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/providers/oauth2/types.ts b/src/providers/oauth2/types.ts index c36bb86a..475c6f96 100644 --- a/src/providers/oauth2/types.ts +++ b/src/providers/oauth2/types.ts @@ -9,7 +9,7 @@ export type OAuth2ProviderIdentitySchema = { }; export type tokenUrlConfigSchema = { - "uses_basic_authentication_scheme"?: boolean; + "use_basic_authentication_scheme"?: boolean; }; export type OAuth2ProviderOptions = { @@ -29,6 +29,8 @@ export type OAuth2ProviderOptions = { "identity_config"?: OAuth2ProviderIdentitySchema; /** Optional extras dict for authorization url for your provider. Required for CUSTOM provider types. */ "authorization_url_extras"?: { [key: string]: string }; + /** Optional boolean flag to specify if the provider requires PKCE. Required for CUSTOM provider types. */ + "use_pkce"?: boolean; }; export type OAuth2ProviderDefinitionArgs = {