-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-existing ENV variables are reported with ??? instead of empty value #226
Labels
Milestone
Comments
seratch
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Jul 5, 2023
yes. do it with - name: "Slack Notify: Deployment Complete"
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
id: slack-notify
env:
SLACK_BOT_TOKEN: ${{ inputs.SlackBotToken }}
DEPLOYRELEASEBRANCH_APPNAME: ${{ inputs.AppName }}
DEPLOYRELEASEBRANCH_APPVERSION: ${{ inputs.AppVersion }}
DEPLOYRELEASEBRANCH_ENVIRONMENT: ${{ inputs.Environment }}
DEPLOYRELEASEBRANCH_JOBNAME: ${{ inputs.JobName }}
DEPLOYRELEASEBRANCH_JOBURL: ${{ inputs.JobUrl }}
DEPLOYRELEASEBRANCH_GITHUBACTOR: ${{ inputs.GithubActor }}
with:
channel-id: ${{ inputs.SlackChannelId }}
update-ts: ${{ inputs.MessageId }}
payload-file-path: ${{ github.action_path }}/slack-notification.json |
Somewhat related, but missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If a env variable which is in payload is missing, ??? are sent instead of empty value.
It would be nice to not put ??? which confuses people but leave it empty (like empty variable).
What type of issue is this? (place an
x
in one of the[ ]
)Requirements (place an
x
in each of the[ ]
)Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version: latest
Steps to reproduce:
Expected result:
Instead of ??? I would expect missing variable to be shown just empty value (bash behavior)
Actual result:
Instead of empty, we get confusing ???
Attachments:
For example:
The text was updated successfully, but these errors were encountered: