Uuid Marker #584
Merged
Uuid Marker #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkleyy
reviewed
May 3, 2019
src/saveload/uuid.rs
Outdated
|
|
||
| /// Set a new uuid. | ||
| pub fn set_uuid(&mut self, uuid: Uuid) { | ||
| self.uuid = uuid; |
There was a problem hiding this comment.
I don't think we should permit this. Won't this invalidate the mapping?
|
|
||
| serde = { version = "1.0", optional = true, features = ["serde_derive"] } | ||
|
|
||
| [features] | ||
| default = ["parallel"] | ||
| parallel = ["rayon", "shred/parallel", "hibitset/parallel"] | ||
| nightly = ["shred/nightly"] | ||
| uuid_entity = ["uuid", "serde"] | ||
| stdweb = ["uuid/stdweb"] | ||
| wasm-bindgen = ["uuid/wasm-bindgen"] |
There was a problem hiding this comment.
Is this something we have to expose?
There was a problem hiding this comment.
if you want to support both stdweb (cargo-web) and wasm then yes.
|
Thanks! |
bors bot
added a commit
that referenced
this pull request
May 3, 2019
584: Uuid Marker r=torkleyy a=jojolepro ## Checklist * [X] I've added tests for all code changes and additions (where applicable) * [ ] I've added a demonstration of the new feature to one or more examples * [ ] I've updated the book to reflect my changes * [X] Usage of new public items is shown in the API docs ## API changes Added UuidMarker and UuidMarkerAllocator. They work the same way their U64 counterparts do. Added "uuid_entity" feature gate. Co-authored-by: Joël Lupien (Jojolepro) <[email protected]>
Build succeeded |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
API changes
Added UuidMarker and UuidMarkerAllocator.
They work the same way their U64 counterparts do.
Added "uuid_entity" feature gate.
This change is