Changes AntiStorage inner to public #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to implement AntiStorage and thus std::ops::Not
bors bot
added a commit
that referenced
this pull request
Jun 11, 2019
603: Changes AntiStorage inner to public r=torkleyy a=jaynus The AntiStorage inner being private prevented any external users of specs to implement an AntiStorage type, which the blanket std::ops::Not implementation requires for allowing negative joins (!&storage). This changes the AntiStorage inner to public, allowing external crates to now implement this appropriately ## Checklist * [x] I've added tests for all code changes and additions (where applicable) * [ ] I've added a demonstration of the new feature to one or more examples * [ ] I've updated the book to reflect my changes * [ ] Usage of new public items is shown in the API docs ## API changes AntiStorage inner is now public Co-authored-by: Walter Pearce <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AntiStorage inner being private prevented any external users of specs to implement an AntiStorage type, which the blanket std::ops::Not implementation requires for allowing negative joins (!&storage).
This changes the AntiStorage inner to public, allowing external crates to now implement this appropriately
Checklist
API changes
AntiStorage inner is now public