Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shred version #671

Merged
merged 5 commits into from
Jan 26, 2020
Merged

Update shred version #671

merged 5 commits into from
Jan 26, 2020

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Jan 19, 2020

Note : it bumps minimal Rust version to 1.38

@azriel91
Copy link
Member

By the way, could you remove the "nightly" feature (and references to it) altogether? It's no longer used (yay!). I think is is an exhaustive list:

  • Cargo.toml
  • src/lib.rs
  • scripts/build-netlify.sh
  • docs/tutorials/src/14_troubleshooting.md (would need to fix the text)

Copy link
Member

@azriel91 azriel91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azriel91
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jan 26, 2020
671: Update shred version r=azriel91 a=allphyr

Note : it bumps minimal Rust version to 1.38

675: Change homepage to specs.amethyst.rs r=azriel91 a=allphyr

Closes #672 

Note : Homepage could be [https://specs.netlify.com](https://specs.netlify.com) instead

Co-authored-by: Benoît du Garreau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2020

Build failed (retrying...)

bors bot added a commit that referenced this pull request Jan 26, 2020
671: Update shred version r=azriel91 a=allphyr

Note : it bumps minimal Rust version to 1.38

Co-authored-by: Benoît du Garreau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2020

Build failed

@a1phyr
Copy link
Contributor Author

a1phyr commented Jan 26, 2020

Those two commits should fix the CI failures

@azriel91
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jan 26, 2020
@bors
Copy link
Contributor

bors bot commented Jan 26, 2020

try

Build failed

@azriel91
Copy link
Member

ah, tynm is me. Shall swap that for unimplemented!().

@azriel91
Copy link
Member

ah, you're fast 🚀

bors r+

bors bot added a commit that referenced this pull request Jan 26, 2020
671: Update shred version r=azriel91 a=allphyr

Note : it bumps minimal Rust version to 1.38

Co-authored-by: Benoît du Garreau <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2020

Build succeeded

@bors bors bot merged commit 2d89cb5 into amethyst:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants