-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceWorkerContainer spec lists onerror
as an event handler
#912
Comments
I can't find any place we fire this error event in gecko. Are we sure no other specs like push or background sync use it, though? |
FYI: Blink looks the same with gecko. onerror isn't defined at the idl file, and I couldn't find any log that onerror has been implemented. |
Pre F2F notes: Seems like this is a hangover from early API sketches. Probably should be removed. We should come up with a plan for error handling. |
F2F: We should remove this |
LGTM. |
w3c/ServiceWorker@c240d9d (w3c/ServiceWorker#912) dropped ServiceWorkerContainer.p.onerror from the spec. So this change marks it deprecated and standard_track:false.
w3c/ServiceWorker@c240d9d (w3c/ServiceWorker#912) dropped ServiceWorkerContainer.p.onerror from the spec. So this change marks it deprecated. Related BCD change: mdn/browser-compat-data#10278
w3c/ServiceWorker@c240d9d (w3c/ServiceWorker#912) dropped ServiceWorkerContainer.p.onerror from the spec. So this change marks it deprecated and standard_track:false. Related MDN change: mdn/content#4703
w3c/ServiceWorker@c240d9d (w3c/ServiceWorker#912) dropped ServiceWorkerContainer.p.onerror from the spec. So this change marks it deprecated. Related BCD change: mdn/browser-compat-data#10278
w3c/ServiceWorker@c240d9d (w3c/ServiceWorker#912) dropped ServiceWorkerContainer.p.onerror from the spec. So this change marks it deprecated. Related BCD change: mdn/browser-compat-data#10278
I think the
ServiceWorkerContainer
spec should not list event handlers.Service Workers 1 and MDN list
onerror
as an attribute ofServiceWorkerContainer
. My tests show that Chrome 51/53, Firefox 47, and Opera 38/39 do not actually supportnavigator.serviceWorker.onerror
, contrary to the Browser Compatibility table in MDN; and thatonerror
is only available from within a service worker object.I later discovered a comment in #199 from @jakearchibald and a comment in #198 from @kinu that indicate
onerror
was moved from the container, so I'm assuming theServiceWorkerContainer
spec just needs to be updated. Correct?StackOverflow ref
The text was updated successfully, but these errors were encountered: