Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The fix provided by #96 does not work #100

Closed
ribeaud opened this issue Aug 20, 2019 · 4 comments · Fixed by #159
Closed

The fix provided by #96 does not work #100

ribeaud opened this issue Aug 20, 2019 · 4 comments · Fixed by #159

Comments

@ribeaud
Copy link
Contributor

ribeaud commented Aug 20, 2019 •
edited
Loading

See #96.
@sloria
Copy link
Owner

sloria commented Aug 20, 2019

Would you like to send another PR to fix the behavior youre seeing?

@ribeaud
Copy link
Contributor Author

ribeaud commented Aug 20, 2019

Yep. But this time, I am going to spend more time on it. Let me a couple of hours... Will come back to you.

@sloria
Copy link
Owner

sloria commented Aug 20, 2019

Thanks!

@sloria sloria mentioned this issue May 28, 2020
Merged
@sloria
Copy link
Owner

sloria commented May 28, 2020

#159 has the bug fix and is released in 8.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix behavior of recurse=True when custom filepath is passed sloria/environs
2 participants
@sloria @ribeaud