Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container: Refactor file/OCI based implementations for verifying and computing digest #220

Open
asraa opened this issue Aug 16, 2022 · 0 comments
Labels
area:container Issue with container provenance verification type:refactor A cleanup or refactor

Comments

@asraa
Copy link
Contributor

asraa commented Aug 16, 2022

Note: would this break if we verify in parallel different images that require changing this global variable?
I don't think we're going to need that any time soon.. unless the unit tests have to.

I wonder whether we this should be a func GetImageDigest() and have an interface that this function implement in a structure. This way anyone who needs to update the function can create their structure and set the function to whatever they want. By default, the function would be the one declared in this file.

Originally posted by @laurentsimon in #147 (comment)

@ianlewis ianlewis added type:refactor A cleanup or refactor area:container Issue with container provenance verification labels Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:container Issue with container provenance verification type:refactor A cleanup or refactor
Projects
None yet
Development

No branches or pull requests

2 participants