Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Re-enable material URI verification #492

Closed
laurentsimon opened this issue Feb 18, 2023 · 1 comment · Fixed by #521
Closed

[feature] Re-enable material URI verification #492

laurentsimon opened this issue Feb 18, 2023 · 1 comment · Fixed by #521
Labels
area:npm An issue with verification of npm packages type:feature New feature request

Comments

@laurentsimon
Copy link
Contributor

Temporarily disabled for https://github.com/gh-community/npm-provenance-private-beta-community/issues/8

@ianlewis ianlewis added type:feature New feature request area:npm An issue with verification of npm packages labels Feb 21, 2023
@laurentsimon
Copy link
Contributor Author

Below is the content of the issue description:

Seems like materials and configSource don't use the same URI:

{
  "_type": "https://in-toto.io/Statement/v0.1",
  ...
    "invocation": {
      "configSource": {
        "uri": "git+https://github.com/laurentsimon/provenance-npm-test@refs/heads/main",
       ...
        "entryPoint": "laurentsimon/provenance-npm-test/.github/workflows/release.yml@refs/heads/main"
      },
    ...
    "materials": [
      {
        "uri": "git+https://github.com/laurentsimon/provenance-npm-test",
       ...
      }
    ]

In all the fields, the URI = git+https://github.com/repo/name@<ref>. In the material, the <ref> is not present.
Is this intentional?

In the https://github.com/slsa-framework/slsa-github-generator repo, we always report the ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:npm An issue with verification of npm packages type:feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants