Trim down endpoints to limited endpoint set #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This removes all endpoints from the Smartcar Node SDK and limits our endpoint set to: info, vin, permissions, disconnect, odometer, location, lock, and unlock.
GregChan
approved these changes
Apr 17, 2018
sankethkatta
approved these changes
Apr 17, 2018
There was a problem hiding this comment.
Do we not need to edit the package.json version? @gurpreetatwal @GregChan
Also will this auto-deploy to npm upon merge?
|
@GregChan ran npm run docs. Please let me know if I can be of further assistance 🙏 |
|
@sankethkatta no need to touch This would be version 2.0.0 since it's a breaking change from 1.0.0 |
|
@gurpreetatwal was this supposed to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all endpoints from the Smartcar Node SDK and limits our endpoint set to: info, vin, permissions, disconnect, odometer, location, lock, and unlock.