Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add CoDel for backpressure queue drops #313

Open
emaxerrno opened this issue Feb 22, 2019 · 1 comment
Open

feature: add CoDel for backpressure queue drops #313

emaxerrno opened this issue Feb 22, 2019 · 1 comment

Comments

@emaxerrno
Copy link
Collaborator

https://queue.acm.org/detail.cfm?id=2209336

we have an implicit fifo queue w/ the future impl.

We need to timestamp the requests at time of accept() w/ the low precision timer (10ms steps) and then drop fast before processing requests.

@emaxerrno
Copy link
Collaborator Author

we have memory backpressure already & timeout already - we need to expose them via the IDL definition.

we will block the processing up to memory limits & also start a timeout on connection parsing.

we need 1 more limits.

  1. accept queue length - implicit at the moment by not processing futures. currently we do
seastar::keep_doing([this] {
    return listener_->accept().then(
      [this, stats = stats_, limits = limits_](
        seastar::connected_socket fd, seastar::socket_address addr) mutable {
        auto conn = seastar::make_lw_shared<rpc_server_connection>(
          std::move(fd), limits, addr, stats, ++connection_idx_);

        open_connections_.insert({connection_idx_, conn});

        // DO NOT return the future. Need to execute in parallel
        handle_client_connection(conn);
      });
  })

  1. we need to drop at handle_client_connection(conn) given a timestamp of the connection such that it looks up the metadata defined on the idl. i.e.:
rpc_service foo {
       foo (InputType): OutputType (codel_2000ms); 
}

and we would parse the backpressure strategy as codel & the timeout for foo would be 2 secs after header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant