unsafe add: will it go back to safe?

[keepsimple1]

polling/src/lib.rs

Line 510 in 77b4ed1

pub unsafe fn add(&self, source: impl AsRawSource, interest: Event) -> io::Result<()> {

Although this seems to have happened almost 6 months ago, it's sad that this API changed to be "unsafe". One of my project relies on this API heavily and we cannot upgrade to the latest "polling" due to this unsafe API.

Is there any plan to make this safe again? ("polling" is a great library, I love using it).

[zeenix]

unsafe only means it's potentially unsafe and shouldn't stop you from using the library in any way. We can lie that it's safe by not declaring it so but all that will do is give you a false sense of safety.

[zeenix]

unsafe only means it's potentially unsafe and shouldn't stop you from using the library in any way. We can lie that it's safe by not declaring it so but all that will do is give you a false sense of safety.

Having said that, looking at the PR that changed it, I'm not sure why this method wasn't just changed to take BorrowedFd instead. @notgull ?

[notgull]

Since the poller uses the reference to the source without considering its lifetime it's essentially taking a raw pointer. I updated the signature to make this clear.

[zeenix]

Since the poller uses the reference to the source without considering its lifetime it's essentially taking a raw pointer. I updated the signature to make this clear.

Thanks for explaining, @notgull. I'm closing this then.

[keepsimple1]

That's really fast to close an issue. It will be good to give the user a chance to follow up before closing ;-)

polling/src/lib.rs

Line 615 in 77b4ed1

pub fn modify(&self, source: impl AsSource, interest: Event) -> io::Result<()> {

I'm wondering, why is modify() able to take AsSource, not AsRawSource?

[notgull]

It is able to take a borrowed pointer because it's not kept around.