Scripting

[msspad]

Some minor issues I found:

• ScriptInit() is run twice, surprising but no big issue
• After clicking on the button "Scripting", the modal message "Are you sure..." pops up. It's somewhat anoying to confirm it every time. Could you remove it? Same is true for the ctb-encryption warning that pops up every time.
• Window size for full screen is not working with a 2 monitor setup on Windows 10?
• It's usefull to understand the different rectangles for writing scripts. Maybe you could add to the method documentation something along the lines:
  -- Operation.OriginalBoundingRectangle is the bounding rectangle of all pixels on all layers
  -- layer.BoundingRectangle is the bounding rectangle of the pixels on a single layer (=not all layers)
  -- Operation.ROI is the rectangle created by the UVTools user with Shift+mouse dragging. Is only defined when user created it.

[sn4k3]

ScriptInit() is run twice, surprising but no big issue

My test (a breakpoint on ScriptInit() + a debug message) shows it trigger only once. A search on solution reveal only one usage call.
Where are you getting this behaviour?

After clicking on the button "Scripting", the modal message "Are you sure..." pops up. It's somewhat anoying to confirm it every time. Could you remove it? Same is true for the ctb-encryption warning that pops up every time.

All tools have confirmation dialog, they wont get removed, but i can introduce a setting so user can opt for no confirmation.
E-CTB message will remain for now

Window size for full screen is not working with a 2 monitor setup on Windows 10?

Need more explanation on this, screenshots.
But programs you set full screen will only do it on current (1) monitor, not both.

It's usefull to understand the different rectangles for writing scripts

The names are self-explanatory, but I can add the missing documentation over them.

SlicerFile.BoundingRectangle is the actual bounds and can change during execution
Operation.OriginalBoundingRectangle is the bounds before operation executed and does not change during execution when a mat has been changed

[msspad]

I will test that under two monitors, but i suspect when you maximize the size event dont fire. Need to check it out.

I forgot to add that "Start maximized" does not restore the window in the screen where UVTools was last closed.

Thats true, when that is checked none of the other are take into consideration, maybe it should?

I obviously can only speak for myself: I would like to have the window open at the same location and same size as when it was last closed (no matter whether maximized or not, no matter on which screen).

I'm also a happy user of ROI.

There's also Masks (Shift + Alt + click), it select masses instead. If you right click on ROI button on UVtools GUI you will see some possible auto selections (presets).

Using masks is a bit more laborous, you need to clone the original mat and keep it intact, then modify the target, in the end call Operation.ApplyMask(original, target) then UVtools will transpose the target modifications to original and set original to target keeping only modifications inside the mask selection. This way you can avoid holes but it require extra effort ofc.

Yes, masks are great, I have used them when applying standard operations in UVTools. In scripts, I prefer to do it directly with OpenCV, also because code can apply some stuff automatically without user intervention.

When manually marking the ROI, I typically draw the ROI over the bounds of Operation.OriginalBoundingRectangle

Ctrl + Shift + B 😉

Didn't know that, thanks. I meant more in scripting, when getting the Operation.ROI Rectangle, it is not capped at Operation.OriginalBoundingRectangle, right?

[sn4k3]

I obviously can only speak for myself: I would like to have the window open at the same location and same size as when it was last closed (no matter whether maximized or not, no matter on which screen).

I can patch to that.

when getting the Operation.ROI Rectangle, it is not capped at Operation.OriginalBoundingRectangle, right?

Correct, ROI is as user selected, is a rectangle which can be empty (0,0,0,0 == !HaveROI) in case of no selection. It won't fall back to VolumeBounds (Which is what GetRoiOrVolumeBounds() does)

[sn4k3]

Using same settings as you with two monitors works to me after maximizing, close, reopen, produces:

[msspad]

My display 1 is scaled at 125%. When I turn it back to 100%, the window behaves as expected. But with 100%, the fonts are too small. Could C#/UVTools scaled displays correctly?

[sn4k3]

Ah scaling... Thats always a problem.
The UI framework still have some bugs regarding scaling. Is out of my scope.