Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.IO.Streams.Process? #69

Open
kindaro opened this issue Jun 10, 2020 · 1 comment
Open

Update System.IO.Streams.Process? #69

kindaro opened this issue Jun 10, 2020 · 1 comment

Comments

@kindaro
Copy link
Collaborator

kindaro commented Jun 10, 2020

System.Process has grown a lot compared to what io-streams re-exports and redefines. For example, I miss withCreateProcess, and I am considering rolling out my own for use in some of the projects I am working on privately. I wonder if I can hope to merge this hypothetical work upstream.

As I project, the change would have three good qualities:

  • It is additive, so it would not affect the existing users that took care to use explicit imports.
  • It is principled, even almost automatic: essentially, all the Handle types have to be converted to appropriate streams with uniform application of only two distinct functions.
  • It is economic, reducing code duplication that is currently evident in the module.

Can this be considered?

@istathar
Copy link
Contributor

I'd suggest just stopping the re-exports from System.IO.Streams.Process. After all, if we want to use functions from System.Process we can just ... import System.Process.

Taking that out, the only functions that are left in System.IO.Stream.Process are runInteractiveCommand and runInteractiveProcess. I think there's scope for additional helper functions, but that's obscured right now by what turns out to be a large pile of re-exports that are not used by those two functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants