Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API enrichment: use configured timeout #759

Open
benjben opened this issue Mar 23, 2023 · 0 comments
Open

API enrichment: use configured timeout #759

benjben opened this issue Mar 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@benjben
Copy link
Contributor

benjben commented Mar 23, 2023

Configured timeout for API enrichment, that ends up here is never used.

The HTTP client used by the enrichment is injected implicitly (here, here and here).

This client uses the default http4s timeout of 45 seconds. This is very high and can introduce ever-growing latency in the pipeline.

The timeout defined in the configuration should be used. We might want to use a dedicated http4s client for the enrichment. This can be the default when we have deprecated Stream Enrich and the use of Id.

@benjben benjben added the bug Something isn't working label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant