You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RDB loader sends alerts via a webhook to a listener, configured here. It is expected that every payload is an actionable alert, to be addressed by the pipeline operator.
There have been times when we've had alerts mis-firing, either due to bugs or due to known external problems. It would be helpful if every alert can be individually silenced, especially while this entire feature is still in an experimental phase.
Currently these are the places where the alerts are fired:
An error message and an exception is raised anywhere else, which causes the app to shut down.
Regarding points 5 and 6, there are several places where we explicitly raise an exception. Often we raise a LoaderError which is a sealed trait. E.g. here and here and here. But occasionally it is not an exception from the sealed trait:
I propose we first extend the LoaderError sealed trait to cover all possible explicit exceptions. (This includes removing LoaderError.RuntimeError, which is too generic). After that, we can have a config block which turns on/off the exception messages and warnings messages. Something like.....
RDB loader sends alerts via a webhook to a listener, configured here. It is expected that every payload is an actionable alert, to be addressed by the pipeline operator.
There have been times when we've had alerts mis-firing, either due to bugs or due to known external problems. It would be helpful if every alert can be individually silenced, especially while this entire feature is still in an experimental phase.
Currently these are the places where the alerts are fired:
Regarding points 5 and 6, there are several places where we explicitly raise an exception. Often we raise a LoaderError which is a sealed trait. E.g. here and here and here. But occasionally it is not an exception from the sealed trait:
IllegalStateException
when something goes wrong initializing the manifest tableRuntimeException
when we cannot read from S3.I propose we first extend the
LoaderError
sealed trait to cover all possible explicit exceptions. (This includes removingLoaderError.RuntimeError
, which is too generic). After that, we can have a config block which turns on/off the exception messages and warnings messages. Something like.....The text was updated successfully, but these errors were encountered: