Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDB Loader: design better error ADT #236

Closed
chuwy opened this issue Dec 7, 2020 · 1 comment
Closed

RDB Loader: design better error ADT #236

chuwy opened this issue Dec 7, 2020 · 1 comment
Assignees
@chuwy

Comments

@chuwy
Copy link
Contributor

chuwy commented Dec 7, 2020 •
edited
Loading

Our error ADT (LoaderError) is bloated without a reason at this point. We should take into account that different kinds of errors must at least bear different kinds of actions/handling. Currently all errors just short-circuit the execution and can be considered fatal. In future we might want to consider certain errors as non-fatal and retry on them (all connection failures), so can be down to:

  • ConnectionError - when caught intialises a sequence of retries
  • FatalError - discovery errors, unhandled runtime errors, migration errors etc

Existing ConfigError also must be out of the ADT as it's not involved in the main flow.
@chuwy chuwy added this to the Release 34 milestone Dec 7, 2020
@chuwy chuwy self-assigned this Dec 7, 2020
@chuwy
Copy link
Contributor Author

chuwy commented Dec 24, 2020

Implement as part of #262

@chuwy chuwy closed this as completed Dec 24, 2020
@chuwy chuwy removed this from the Release 35 milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chuwy