Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDB Loader: execute manifest insert in same transaction as load #36

Closed
chuwy opened this issue Aug 24, 2017 · 4 comments
Closed

RDB Loader: execute manifest insert in same transaction as load #36

chuwy opened this issue Aug 24, 2017 · 4 comments
Assignees
@chuwy
Milestone
Release 28

Comments

@chuwy
Copy link
Contributor

chuwy commented Aug 24, 2017

@alexanderdean, I think I copied this behavior (two distinct transactions) from StorageLoader, but wasn't single transaction a whole point of having manifest in the same storage target?
@alexanderdean
Copy link
Member

alexanderdean commented Aug 24, 2017 •
edited
Loading

The manifest is already in the same transaction? Per the dry-run... The second transaction is the analyze.

@chuwy
Copy link
Contributor Author

chuwy commented Aug 24, 2017

No, they're always in two distinct transactions.

@alexanderdean
Copy link
Member

Oh! Yes, then, that's a bug.

@alexanderdean alexanderdean added this to the Version 0.14.0 milestone Aug 24, 2017
@alexanderdean
Copy link
Member

Can wait till 0.14.0 (I put 0.13.0-rc4 live on all the canaries BTW)

@chuwy chuwy changed the title Execute manifest insert in same transaction as load RDB Loader: execute manifest insert in same transaction as load Sep 29, 2017
@chuwy chuwy closed this as completed in 3f8c69f Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

Labels
None yet
Projects
None yet
Milestone
Release 28
Development

No branches or pull requests
2 participants
@alexanderdean @chuwy