fix: specify targetFile for pipenv projects

snyk · Aug 6, 2018 · 9647686 · 9647686
1 parent e567e3a
commit 9647686
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -31,7 +31,7 @@ function inspect(root, targetFile, options) {
   }
 
   return Promise.all([
-    getMetaData(command, baseargs, root),
+    getMetaData(command, baseargs, root, targetFile),
     getDependencies(
       command,
       baseargs,
@@ -50,7 +50,7 @@ function inspect(root, targetFile, options) {
     });
 }
 
-function getMetaData(command, baseargs, root) {
+function getMetaData(command, baseargs, root, targetFile) {
   return subProcess.execute(
     command,
     [].concat(baseargs, ['--version']),
@@ -60,6 +60,9 @@ function getMetaData(command, baseargs, root) {
       return {
         name: 'snyk-python-plugin',
         runtime: output.replace('\n', ''),
+        // specify targetFile only in case of Pipfile
+        targetFile:
+          (path.basename(targetFile) === 'Pipfile') ? targetFile : undefined,
       };
     });
 }

diff --git a/test/inspect.test.js b/test/inspect.test.js
@@ -126,6 +126,7 @@ test('inspect', function (t) {
         t.ok(plugin, 'plugin');
         t.equal(plugin.name, 'snyk-python-plugin', 'name');
         t.match(plugin.runtime, 'Python', 'runtime');
+        t.notOk(plugin.targetFile, 'no targetfile for requirements.txt');
         t.end();
       });
 
@@ -468,8 +469,11 @@ test('inspect Pipfile', function (t) {
       return plugin.inspect('.', 'Pipfile');
     })
     .then(function (result) {
+      var plugin = result.plugin;
       var pkg = result.package;
 
+      t.equal(plugin.targetFile, 'Pipfile', 'Pipfile targetfile');
+
       t.test('package dependencies', function (t) {
         t.notOk(pkg.dependencies['django'], 'django skipped (editable)');