Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Controller requires sage namespace to be App #104

Closed
briggySmalls opened this issue Oct 9, 2018 · 0 comments
Closed

Controller requires sage namespace to be App #104

briggySmalls opened this issue Oct 9, 2018 · 0 comments

Comments

@briggySmalls
Copy link
Contributor

briggySmalls commented Oct 9, 2018

First: Thanks for a wonderful tool. I appreciate all the work you people are doing 🙇

Upgrading my Sage theme to 9.0.5 has lead to no controllers being found - breaking my site - because I have changed the Sage namespace from the default App. I am greeted with the error:

Fatal error: Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Class 'App' not found in ...

Along with the path for the compiled page-header.blade.php with its reference to the App controller.

I have traced this to the assumptions in controller.php that the sage() function is to be fully namespaced as App\sage(). These are, as far as I can see:

I have verified that I can fix my site by changing these lines to use my theme's non-default namespace. I also need to make use of the sober/controller/namespace filter to ensure the controllers are found.

Having opened a discussion on the roots forum it was suggested I open an issue here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant