Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about binary #21

Open
Totodore opened this issue Aug 25, 2024 · 0 comments
Open

Improve documentation about binary #21

Totodore opened this issue Aug 25, 2024 · 0 comments

Comments

@Totodore
Copy link

Totodore commented Aug 25, 2024

Hi,

While implementing a msgpack parser for the rust server implementation. I discovered (if I understood this correctly), that:

  • The attachment count in msgpack for binary is never sent.
  • The packet type is always EVENT or ACK and never BINARY_EVENT or BINARY_ACK even if there are binaries in the payload.

These information are quite important and also having a documentation about this would secure breaking changes between two versions of this parser (it would break compatibility with my version then).

Could you confirm the two assumptions above @darrachequesne ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant