Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): expose additional needed types #3684

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(typings): expose additional needed types #3684

merged 1 commit into from
Nov 9, 2020

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Nov 8, 2020

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Needed interfaces/types are not exposed. @types/socket.io used to export these.

New behaviour

Exported needed types.

Other information (e.g. related issues)

Noticed while upgrading. Will create a similar PR to socket.io-client.
May want to consider adding the type modifier to the export, so that the actual abstractions won't be exposed. Downside: it will make the .d.ts only compatible with [email protected]+.

Off-topic

You using TypeScript and publishing built-in .d.ts is awesome.

@types/socket.io used to export these
@darrachequesne darrachequesne merged commit f62f180 into socketio:master Nov 9, 2020
@darrachequesne
Copy link
Member

@AviVahl thanks!

@darrachequesne darrachequesne added this to the 3.0.1 milestone Nov 11, 2020
@ptejada
Copy link
Contributor

ptejada commented Nov 18, 2020

Any ideas why I am getting this error when trying to import Socket?

image

I am not using typescript and only doing the import for JSDoc type hints. Last version I tried was 3.0.2

dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants