Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite: adding tests for discarding messages on #close in polling transport #29

Open
botanicus opened this issue Dec 13, 2011 · 2 comments
Assignees

Comments

@botanicus
Copy link

There's a significant difference between behaviour of primitive transports such as polling and more advanced transport such as websockets in case of closing connection in user app (see http://pastie.org/pastes/3011573). So whereas websocket tranport do deliver all the messages, primitive transports buffer messages and if user call #close, buffer won't be ever send, hence these messages shall not be delivered.

This behaviour should be tested.

@majek
Copy link
Member

majek commented Dec 13, 2011

Also, we should test what happens when one sends a message if the session is in 'closed' state. The message should be discarded, but the 'send' shouldn't raise 404.

@botanicus
Copy link
Author

Good point.

@ghost ghost assigned majek Feb 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants