Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong asserts for callback #90

Open
fleonis opened this issue Nov 12, 2015 · 2 comments
Open

wrong asserts for callback #90

fleonis opened this issue Nov 12, 2015 · 2 comments

Comments

@fleonis
Copy link

fleonis commented Nov 12, 2015

hello

it seems wrong to test like this

self.assertTrue('"callback" parameter required' in r.body)

the body should content something like this

c["\"callback\" parameter required"]

or like this

p("c[\"\"callback\" parameter required\"]");

so?

and test fails

@brycekahle
Copy link
Contributor

Which test? Can you link to a line?

@fleonis
Copy link
Author

fleonis commented Nov 18, 2015

self.assertTrue('invalid "callback" parameter' in r.body)

self.assertTrue('"callback" parameter required' in r.body)

self.assertTrue('invalid "callback" parameter' in r.body)

self.assertTrue('"callback" parameter required' in r.body)

but may be more.. i cannot test it for now

and i mean the body

c["\"callback\" parameter required"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants