Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DiagnosticAdded gracefully + investigate scarb doc working for code that doesn't compile #1445

Closed
piotmag769 opened this issue Jul 12, 2024 · 0 comments
Closed

Handle DiagnosticAdded gracefully + investigate scarb doc working for code that doesn't compile #1445

piotmag769 opened this issue Jul 12, 2024 · 0 comments
Assignees
@wawel37
Labels
scarb-doc
Milestone
Scarb Doc

Comments

@piotmag769
Copy link
Contributor

piotmag769 commented Jul 12, 2024 •
edited
Loading

Sometimes when an error during compilation happens we panic, we should bubble the error instead.

We should check if it doesn't also happen for warnings/other situations

Sometimes scarb doc also works for code that doesn't compile
@piotmag769 piotmag769 changed the title Handle DiagnosticAdded gracefully Handle DiagnosticAdded gracefully + investigate scarb doc working for code that doesn't compile Jul 16, 2024
@maciektr maciektr added this to the Scarb Doc milestone Aug 13, 2024
@wawel37 wawel37 self-assigned this Aug 20, 2024
@wawel37 wawel37 mentioned this issue Sep 11, 2024
Merged
@wawel37 wawel37 closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wawel37 wawel37

Labels
scarb-doc
Projects
Scarb
Archived in project
Milestone
Scarb Doc
Development

No branches or pull requests
3 participants
@wawel37 @maciektr @piotmag769