Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create on Read breaks fs usage (fix proposed) #11

Open
joel-wright opened this issue Oct 21, 2013 · 3 comments
Open

Create on Read breaks fs usage (fix proposed) #11

joel-wright opened this issue Oct 21, 2013 · 3 comments
Labels

Comments

@joel-wright
Copy link

Create on read has conflicting requirements to usage as a filesystem. In order to allow create on read we have to also have getattr return something sensible for files not in the fs list. Unfortunately, this means that when we try to mkdir, getattr returns attributes that tell the system the file/directory already exists.

Will look into ways to fix it

@joel-wright
Copy link
Author

The only thing I can come up with atm is to disallow folder names that match valid filenames.

@joel-wright
Copy link
Author

The only other option I can come up with is to only allow folders at the root of the fs, and only files within the first level folders. This would allow me to distinguish between "getattr for file creation" and "getattr for mkdir".

@joel-wright
Copy link
Author

Proposed fix pushed to alpha.

The only thing missing is create-on-read at the root level when mounted as a filesystem. Create on read within folders still works, and mkdir is working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant