Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: getConfirmedBlock doesn't include collected rent #10085

Closed
jstarry opened this issue May 17, 2020 · 2 comments
Closed

RPC: getConfirmedBlock doesn't include collected rent #10085

jstarry opened this issue May 17, 2020 · 2 comments
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Milestone

Comments

@jstarry
Copy link
Member

jstarry commented May 17, 2020

Problem

Rent collection happens when accounts are newly created as well as at epoch boundaries (through eager rent collection). Currently, the rent dues are not included in getConfirmedBlock and so clients have no idea that they were collected (unless they calculate them).

Proposed Solution

Either add (account, rent) to the rewards object (treat as negative rewards) OR add a new object for rent.

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 2, 2021
@CriesofCarrots
Copy link
Contributor

Hey hey, It does now! #17504 and (txs) #17528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

3 participants