Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web3.js] Replace js-sha3 dependency for keccak-ing #27629

Closed
Tracked by #1103
steveluscher opened this issue Sep 6, 2022 · 0 comments · Fixed by #27630
Closed
Tracked by #1103

[web3.js] Replace js-sha3 dependency for keccak-ing #27629

steveluscher opened this issue Sep 6, 2022 · 0 comments · Fixed by #27630
Labels
community Community contribution javascript Pull requests that update Javascript code

Comments

@steveluscher
Copy link
Contributor

steveluscher commented Sep 6, 2022 •
edited
Loading

Problem

js-sha3 is likely replaceable with @noble/hashes/sha3 which could save us another chunk of kilobytes and eliminate another dependency.

image

Proposed solution

Investigate doing so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community Community contribution javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace js-sha3 with @noble/hashes/sha3
1 participant
@steveluscher