Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QUIC for repair #28636

Open
behzadnouri opened this issue Oct 27, 2022 · 2 comments
Open

Use QUIC for repair #28636

behzadnouri opened this issue Oct 27, 2022 · 2 comments
Assignees
@behzadnouri
Labels
do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot

Comments

@behzadnouri
Copy link
Contributor

Problem

UDP lacks features to effectively support QoS.

Proposed Solution

  • Investigate using QUIC for repair.
  • May also use 2-way connections for receiving repair shreds.
@lijunwangs lijunwangs self-assigned this Nov 22, 2022
@behzadnouri
Copy link
Contributor Author

behzadnouri commented Feb 3, 2023 •
edited
Loading

Some current observed quic vs udp regressions:

These likely need to be resolved before we can migrate further protocols to quic.

Additionally mixing synchronization primitives apparently causing hickups:
https://discord.com/channels/428295358100013066/1070788493040697354/1070912358714707988

those hickups might have been amplified through the growing use of tokio in seemingly unrelated parts (tpu/quic) of the validator, now causing a leaky bucket to overflow on the rpc side

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Feb 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
@behzadnouri behzadnouri added do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot and removed stale [bot only] Added to stale content; results in auto-close after a week. labels Feb 20, 2024
@behzadnouri
Copy link
Contributor Author

Repair over QUIC is fully implemented and tested over gce clusters:
https://github.com/solana-labs/solana/blob/d48f27709/core/src/repair/quic_endpoint.rs
However, firedancer team is proposing a new UDP based protocol.
Given the overhead and complexities of QUIC, we will wait until that proposal has panned out before migrating repair off UDP protocol.

@behzadnouri behzadnouri reopened this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behzadnouri behzadnouri

Labels
do-not-close Add this tag to exempt an issue/PR from being closed by the stalebot
Projects
Networking v1.15 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behzadnouri @lijunwangs