We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here bank.parent_hash() used as parent_blockhash for notify_block_metadata() func and futher send as parent_blockhash field into GeyserPlugin notify_block_metadata(): https://github.com/solana-labs/solana/blob/421b1d4f88148064f5f91eaf24d2481caea1ea3a/core/src/replay_stage.rs#L2844C25-L2844C57 This field in fact incorrect, because parent_blockhash must represent blockhash, but not a hash of parent block I propose to add here https://github.com/solana-labs/solana/blob/667bc163426aa075e127d7e58e06ffb11f9e20a2/runtime/src/bank.rs#L1561C15-L1561C15 not only parent_hash, but also parent_blockhash field and build it as parent_blockhash: parent.last_blockhash() And futher use this field instead of parent_hash for notify_block_metadata
bank.parent_hash()
parent_blockhash
notify_block_metadata()
parent_blockhash: parent.last_blockhash()
notify_block_metadata
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Here
bank.parent_hash()used asparent_blockhashfornotify_block_metadata()func and futher send asparent_blockhashfield into GeyserPluginnotify_block_metadata():https://github.com/solana-labs/solana/blob/421b1d4f88148064f5f91eaf24d2481caea1ea3a/core/src/replay_stage.rs#L2844C25-L2844C57
This field in fact incorrect, because parent_blockhash must represent blockhash, but not a hash of parent block
I propose to add here
https://github.com/solana-labs/solana/blob/667bc163426aa075e127d7e58e06ffb11f9e20a2/runtime/src/bank.rs#L1561C15-L1561C15
not only parent_hash, but also parent_blockhash field and build it as
parent_blockhash: parent.last_blockhash()And futher use this field instead of parent_hash for
notify_block_metadataThe text was updated successfully, but these errors were encountered: