Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Gate: cost model uses number of requested write locks #34819

Open
apfitzge opened this issue Jan 18, 2024 · 0 comments
Open

Feature Gate: cost model uses number of requested write locks #34819

apfitzge opened this issue Jan 18, 2024 · 0 comments
Labels
feature-gate Pull Request adds or modifies a runtime feature gate

Comments

@apfitzge
Copy link
Contributor

apfitzge commented Jan 18, 2024 •
edited
Loading

SIMD

N/A

Description

  • Some write-locks are demoted to read-locks during transaction sanitization
  • Change the cost model to apply write lock costs for the number of requested write locks, instead of the number of write-locks after demotion
  • Requires feature-gate so that activation of 2ry7ygxiYURULZCrypHhveanvP5tzZ4toRwVp89oCNSj (Feature Gate: Validator applies cost tracker to blocks during replay #29595) will not cause this change to break consensus

Feature ID

wLckV1a64ngtcKPRGU4S4grVTestXjmNjxBjaKZrAcn

Activation Method

Single Core Contributor

Deployment Considerations

Unit test on the cost model have been added.
No special considerations for deployment.

Minimum Beta Version

1.18.0

Minimum Stable Version

1.18.0

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response
@apfitzge apfitzge added the feature-gate Pull Request adds or modifies a runtime feature gate label Jan 18, 2024
@apfitzge apfitzge changed the title Feature Gate: Feature Gate: cost model uses number of requested write locks Jan 18, 2024
@apfitzge apfitzge mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apfitzge