Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for editing draft document #3

Open
cocoyoon opened this issue Nov 8, 2023 · 0 comments
Open

Request for editing draft document #3

cocoyoon opened this issue Nov 8, 2023 · 0 comments

Comments

@cocoyoon
Copy link

cocoyoon commented Nov 8, 2023

I suggest editing some example fields on draft document.

  1. Since the response from the server includes Accept-Signature: sig1=("@method", "@target-uri");created;nonce, section 3.1.4 3. The Client Signs the Header, shouldn't sig1 contain those components at least?
- Current 
"@signature-params": ("@request-target" "authorization");keyid="/keys/alice#";\
   created=1617265800;expires=1617320700

- Maybe
"@signature-params": ("@method, @target-uri, "authorization");keyid="/keys/alice#";\
   created=1617265800;expires=1617320700;nonce={..}
  1. On section 4.1 The keyid URL example HTTP message, I think there is a typo. Authorization: HttpSig proof=sig2 -> Authorization: HttpSig proof=sig1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant