Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "possible future" label from acl:trustedApp paragraph #38

Closed
michielbdejong opened this issue Mar 7, 2019 · 15 comments · Fixed by #56
Closed

remove "possible future" label from acl:trustedApp paragraph #38

michielbdejong opened this issue Mar 7, 2019 · 15 comments · Fixed by #56

Comments

@michielbdejong
Copy link
Contributor

In today's community meeting, we decided to go ahead with the acl:trustedApp system, so we should reword https://github.com/solid/web-access-control-spec#possible-future to say that it's currently part of the spec.

@gobengo
Copy link

gobengo commented Apr 4, 2019

It seems like a good idea to pursue. I think the 'reword' part is important to make the text normative. So it's a bit more than just removing the "possible future" label as the title here might imply.

@namedgraph
Copy link

Please don't pollute the WAC namespace with Solid-specific terms.

WAC quite clearly defines permissions for the document space.

However "applications" are another dimension, strictly orthogonal to documents. Therefore mixing acl:trustedApp with the existing document-space terms makes no sense.

Please choose a namespace (under https://solid.inrupt.com/ ?) different from acl:, and a separate ontology that imports acl:.

@michielbdejong
Copy link
Contributor Author

Please don't pollute the WAC namespace with Solid-specific terms.

But acl:trustedApp is not Solid-specific, it's WAC-specific. I thought there was a 1:1 relationship between http://www.w3.org/ns/auth/acl# and this spec? Is the WAC spec not the only user of that namespace?

@namedgraph
Copy link

namedgraph commented May 24, 2019

The WAC ontology homepage is https://www.w3.org/wiki/WebAccessControl.
This spec is clearly under Solid's documentation.

As I explained, acl:trustedApp is orthogonal to the rest of terms and therefore out of place.

@michielbdejong
Copy link
Contributor Author

oh bummer so then we have two competing WAC specs. I see that https://www.w3.org/wiki/WebAccessControl calls it acl:trustedOrigin instead of acl:trustedApp.

We should definitely merge https://www.w3.org/wiki/WebAccessControl and https://github.com/solid/web-access-control-spec into one.

@namedgraph are you aware of anyone using the acl:trustedOrigin predicate in production?

cc @RubenVerborgh

@namedgraph
Copy link

I don't know where the trusted stuff comes from because it's not in https://www.w3.org/ns/auth/acl

And no I'm not aware. As far as I'm concerned, the core of WAC is Authorization, Mode, accessTo(Class) and agent(Class).

@michielbdejong
Copy link
Contributor Author

Interesting! And who apart from Solid are using https://www.w3.org/ns/auth/acl, then? So maybe we have three versions of what WAC is then, this github repo, the wiki, and the vocab document...

@namedgraph can you maybe weigh in on #51?

@kjetilk
Copy link
Member

kjetilk commented May 27, 2019

I must admit I'm still not confident about acl:trustedApp's scalability properties. Before that, ACL resource caching was quite easy to achieve, and ACL checking implemented on the top of that cache. With acl:trustedApp, I'm not sure how it will play out in practice, if we could end up in a situation where there are a lot of user profiles involved, and where caching could get messy, given that people edit their user profiles for many other reasons than ACL maintenance. Since ACL checking is something we do for every request, we need to be careful about it, and don't feel confident it will play out well at scale. It is possible that lazy checking will help, but also that there are sufficiently many cases where too much data needs to be fetched to allow for efficient ACL checking.

@michielbdejong
Copy link
Contributor Author

@kjetilk This issue is about updating the spec text to match what we decided in March.

@kjetilk
Copy link
Member

kjetilk commented May 27, 2019

@kjetilk This issue is about updating the spec text to match what we decided in March.

Yes, I know, and I think we might have been a bit hasty, and therefore, it shouldn't be removed before we have some empirical evidence for its consequences.

@michielbdejong
Copy link
Contributor Author

I agree with you that we should move to something better than what we have now, but keeping this document out of sync with reality is not going to fix it. :)

Is it ok with you if we merge #56, and then work on a more granular consent system in the vein of solid/solid-spec#176 or other similar systems we could now start proposing?

@kjetilk
Copy link
Member

kjetilk commented May 28, 2019

The question is really the process of deprecating things that have been implemented once it has been in the spec. If it says "possible future", then it is quite clear that it has been implemented as an experimental feature, so I don't think there is really a disconnect with reality in it, it is OK to implement "possible futures" as experimental features at any time.

But OTOH, we're not a working group producing a Recommendation here, I suppose removing it if we have seen it doesn't scale in a WG setting wouldn't be difficult to argue. So, I could live with merging #56, but I'd prefer not.

@michielbdejong
Copy link
Contributor Author

ok, so you how about if we replace 'possible future' (which is factually incorrect) with 'experimental', which warns that it's probably more subject to change than some of the other parts?

@kjetilk
Copy link
Member

kjetilk commented May 28, 2019

Yeah, that works for me, if it works for others.

@michielbdejong
Copy link
Contributor Author

Great! Updated #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants