Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching for download enpoint #2

Open
j92 opened this issue Jul 13, 2021 · 0 comments
Open

Caching for download enpoint #2

j92 opened this issue Jul 13, 2021 · 0 comments

Comments

@j92
Copy link
Collaborator

j92 commented Jul 13, 2021

We should add caching for downloaded files from AWS as we pay for each download.

Should we cache all files?

Sounds like a bad idea, as the cache will be overloaded.
We could decide per file size if the file should be cached.
For getting the filesize we have two options:

  1. Store the size of the file somewhere on uploading.
  2. Do a HEAD request to AWS.

Should users be able to bypass the cache?

For the main API I don't think that will be needed as we need caching primarily to avoid unnecessary spendings.

Adapter

  1. InMemory Adapter
  2. Bring your own (Redis) adapter?
@j92 j92 changed the title Caching: Download enpoint Caching for download enpoint Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant