Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature?]: Allow to dynamic environment variables in dist mode #1141

Closed
2 tasks done
BierDav opened this issue Dec 14, 2023 · 1 comment
Closed
2 tasks done

[Feature?]: Allow to dynamic environment variables in dist mode #1141

BierDav opened this issue Dec 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@BierDav
Copy link
Contributor

BierDav commented Dec 14, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Currently when you use environment variables with solid-start build all variables get instantly inlined, which is a bit annoying when you try to use the build result as a docker image, for example where I might want to override some variables

Examples 🌈

We store the client id for the API as an environment variable, and we would like to be able to configure it in the docker-compose file

Motivation 🔦

No response

@BierDav BierDav added the enhancement New feature or request label Dec 14, 2023
@ryansolid
Copy link
Member

In setting up for SolidStart's next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See #1139 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants